fix jwt-cpp on_test #5366
fix jwt-cpp on_test #5366
Conversation
| ]]}, {configs = {languages = "c++11"}})) | ||
| if package:config("picojson") then | ||
| assert(package:check_cxxsnippets({test = [[ | ||
| #include <jwt-cpp/jwt.h> |
There was a problem hiding this comment.
Could you please provide more information about this change? When the picojson feature is disabled with this patch, it will be completely untested.
There was a problem hiding this comment.
If I use add_requires("jwt-cpp", {configs = {picojson = false}}), the situation shown in the figure will appear when installing the package
There was a problem hiding this comment.
I understand. In this case, the current port of the package can be enhanced by incorporating additional JSON trait features, such as Boost.JSON or nlohmann_json. These dependencies should be added when the feature is enabled. Otherwise, simply disabling the on_test won't be very effective.
There was a problem hiding this comment.
Yes, I use nlohmann-json by add_requires in my project code, I just want to be able to install jwt after disabling picojson.
If the programmer actively turns off this picojson config, it means that he is consciously using other json libraries.
There was a problem hiding this comment.
Need refactor the package
|
No issue? I merged |
check package:config("picojson") before on_test