Python: If headeronly is set, links is not needed #5403
+35
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
不要提交到 master，我默认分支都切到 dev 了，就是为了避免误提交，怎么还往 master 提 |
Don't submit to master. By default, I have switched branches to dev just to avoid mistaken submissions. Why do I still submit to master? |
|
因为那个 fork 是很早做的, 还在 master. 已经修改到了 dev |
Because that fork was done very early and is still on master |
waruqi
reviewed
Oct 2, 2024
waruqi
reviewed
Oct 2, 2024
waruqi
reviewed
Oct 2, 2024
waruqi
reviewed
Oct 2, 2024
waruqi
reviewed
Oct 2, 2024
waruqi
reviewed
Oct 2, 2024
waruqi
reviewed
Oct 2, 2024
waruqi
reviewed
Oct 2, 2024
|
不要带中文 commit |
Don’t bring Chinese commit |
waruqi
reviewed
Oct 3, 2024
| -- Linking libpythonX.Y.so is not allowed on manylinux, which is the base image for distributing C extensions. | ||
|
|
||
| -- see https://gitlab.kitware.com/cmake/cmake/-/issues/20425 and | ||
| -- https://peps.python.org/pep-0513/#libpythonx-y-so-1 |
waruqi
reviewed
Oct 3, 2024
|
|
||
| -- see https://gitlab.kitware.com/cmake/cmake/-/issues/20425 and | ||
| -- https://peps.python.org/pep-0513/#libpythonx-y-so-1 | ||
|
|
waruqi
reviewed
Oct 3, 2024
| local python_headeronly = package:config("python_headeronly") | ||
| if is_host("windows") then | ||
| wprint("Python headeronly is not supported on Windows") | ||
| python_headeronly = false |
There was a problem hiding this comment.
如果 windows 不支持，应该 add_configs 时候，直接设置为 readonly = true, default = false 锁定住，原本就会自动给 warning 。。不用额外检测
waruqi
reviewed
Oct 3, 2024
|
|
||
| package:add("deps", "python 3.x", {configs = { | ||
| headeronly = python_headeronly, | ||
| }}) |
waruqi
reviewed
Oct 3, 2024
| result.linkdirs = libpath.linkdir | ||
| end | ||
| if not includepath then | ||
| return false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking libpythonX.Y.so is not allowed on manylinux. So I change the Python fetch logic to allow building without libdir on manylinux.
#5391