Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Nov 9, 2025

New version of ktx detected (package version: v4.4.0, last github version: v4.4.2)

@waruqi waruqi added the auto-update Automatic update label Nov 9, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automatically updates the ktx package to its latest version, v4.4.2. This ensures that the project leverages the most recent stable release of the KTX library, incorporating any bug fixes, performance enhancements, or new features introduced in this update.

Highlights

  • KTX Package Version Update: The ktx package definition in xmake.lua has been updated to include the new version v4.4.2, along with its corresponding commit hash.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ktx package to version v4.4.2. The change itself is straightforward, but it appears to have missed applying an existing patch to the new version. The patch for version v4.4.0 handles dependency unbundling, and it's likely still necessary for v4.4.2. I've added a comment with details on this potential issue.

add_urls("https://github.com/KhronosGroup/KTX-Software/archive/refs/tags/$(version).tar.gz",
"https://github.com/KhronosGroup/KTX-Software.git", {submodules = false})

add_versions("v4.4.2", "9412cb45045a503005acd47d98f9e8b47154634a50b4df21e17a1dfa8971d323")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding the new version v4.4.2, it seems the patch for unbundling dependencies applied to version v4.4.0 will not be applied for this new version. The build for v4.4.2 will likely use the bundled astc-encoder dependency, which is probably not the desired behavior for this repository.

Please verify if the dep-unbundle.patch is still required for v4.4.2. If so, you should also apply it to this version. You could either add a new add_patches call for v4.4.2, or preferably, modify the existing one to apply to all 4.4.x versions using a semver range like ~4.4.0 to improve future maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants