-
-
Notifications
You must be signed in to change notification settings - Fork 490
Auto-update ktx to v4.4.2 #8587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automatically updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the ktx package to version v4.4.2. The change itself is straightforward, but it appears to have missed applying an existing patch to the new version. The patch for version v4.4.0 handles dependency unbundling, and it's likely still necessary for v4.4.2. I've added a comment with details on this potential issue.
| add_urls("https://github.com/KhronosGroup/KTX-Software/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/KhronosGroup/KTX-Software.git", {submodules = false}) | ||
|
|
||
| add_versions("v4.4.2", "9412cb45045a503005acd47d98f9e8b47154634a50b4df21e17a1dfa8971d323") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding the new version v4.4.2, it seems the patch for unbundling dependencies applied to version v4.4.0 will not be applied for this new version. The build for v4.4.2 will likely use the bundled astc-encoder dependency, which is probably not the desired behavior for this repository.
Please verify if the dep-unbundle.patch is still required for v4.4.2. If so, you should also apply it to this version. You could either add a new add_patches call for v4.4.2, or preferably, modify the existing one to apply to all 4.4.x versions using a semver range like ~4.4.0 to improve future maintainability.
New version of ktx detected (package version: v4.4.0, last github version: v4.4.2)