Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Nov 26, 2025

New version of fakeit detected (package version: 2.4.1, last github version: 2.5.0)

@waruqi waruqi added the auto-update Automatic update label Nov 26, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the process of keeping project dependencies current by integrating the latest 2.5.0 release of the fakeit mocking framework. This ensures the project benefits from the most recent features, bug fixes, and compatibility improvements offered by the updated library.

Highlights

  • Dependency Update: The fakeit mocking framework has been updated to version 2.5.0. This update introduces the new version and its corresponding SHA-256 hash into the xmake.lua configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automatically updates the fakeit package to version 2.5.0. The version update itself is correct. However, I've identified an opportunity to improve the maintainability and clarity of the package definition file. My review includes a suggestion to use URL aliases to explicitly associate version hashes with their corresponding source archives, which is a good practice seen in other packages in this repository. This change will make the package definition more robust.

Comment on lines 7 to 12
add_urls("https://github.com/eranpeer/FakeIt/archive/refs/tags/$(version).tar.gz",
"https://github.com/eranpeer/FakeIt.git")

add_versions("2.5.0", "57adedf802271513d88a1d9342d829cfb34988c3d835e07346f8129047200c53")
add_versions("2.4.1", "f5234a36d42363cb7ccd2cf99c8a754c832d9092035d984ad40aafa5371d0e95")
add_versions("2.4.0", "eb79459ad6a97a5c985e3301b0d44538bdce2ba26115afe040f3874688edefb5")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better clarity and to avoid ambiguity when multiple URLs are present, it's good practice to assign aliases to each URL using add_urls and then reference them in add_versions. This makes it explicit that the SHA256 hashes correspond to the tarball archives and not the git repository URL.

This pattern is already used in other package definitions within this repository (e.g., gtest, boost) and would improve the robustness of this package definition.

Note: Applying this suggestion might require updating the autoupdate.lua script to handle the alias:version format when parsing versions.

    add_urls("https://github.com/eranpeer/FakeIt/archive/refs/tags/$(version).tar.gz", {alias = "archive"})
    add_urls("https://github.com/eranpeer/FakeIt.git", {alias = "git"})

    add_versions("archive:2.5.0", "57adedf802271513d88a1d9342d829cfb34988c3d835e07346f8129047200c53")
    add_versions("archive:2.4.1", "f5234a36d42363cb7ccd2cf99c8a754c832d9092035d984ad40aafa5371d0e95")
    add_versions("archive:2.4.0", "eb79459ad6a97a5c985e3301b0d44538bdce2ba26115afe040f3874688edefb5")

@github-actions github-actions bot merged commit 82ad503 into dev Nov 26, 2025
61 checks passed
@github-actions github-actions bot deleted the autoupdate-fakeit-2.5.0 branch November 26, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update Automatic update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants