-
-
Notifications
You must be signed in to change notification settings - Fork 490
Auto-update fakeit to 2.5.0 #8691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the process of keeping project dependencies current by integrating the latest Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the fakeit package to version 2.5.0. The version update itself is correct. However, I've identified an opportunity to improve the maintainability and clarity of the package definition file. My review includes a suggestion to use URL aliases to explicitly associate version hashes with their corresponding source archives, which is a good practice seen in other packages in this repository. This change will make the package definition more robust.
| add_urls("https://github.com/eranpeer/FakeIt/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/eranpeer/FakeIt.git") | ||
|
|
||
| add_versions("2.5.0", "57adedf802271513d88a1d9342d829cfb34988c3d835e07346f8129047200c53") | ||
| add_versions("2.4.1", "f5234a36d42363cb7ccd2cf99c8a754c832d9092035d984ad40aafa5371d0e95") | ||
| add_versions("2.4.0", "eb79459ad6a97a5c985e3301b0d44538bdce2ba26115afe040f3874688edefb5") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better clarity and to avoid ambiguity when multiple URLs are present, it's good practice to assign aliases to each URL using add_urls and then reference them in add_versions. This makes it explicit that the SHA256 hashes correspond to the tarball archives and not the git repository URL.
This pattern is already used in other package definitions within this repository (e.g., gtest, boost) and would improve the robustness of this package definition.
Note: Applying this suggestion might require updating the autoupdate.lua script to handle the alias:version format when parsing versions.
add_urls("https://github.com/eranpeer/FakeIt/archive/refs/tags/$(version).tar.gz", {alias = "archive"})
add_urls("https://github.com/eranpeer/FakeIt.git", {alias = "git"})
add_versions("archive:2.5.0", "57adedf802271513d88a1d9342d829cfb34988c3d835e07346f8129047200c53")
add_versions("archive:2.4.1", "f5234a36d42363cb7ccd2cf99c8a754c832d9092035d984ad40aafa5371d0e95")
add_versions("archive:2.4.0", "eb79459ad6a97a5c985e3301b0d44538bdce2ba26115afe040f3874688edefb5")
New version of fakeit detected (package version: 2.4.1, last github version: 2.5.0)