Skip to content

Commit

Permalink
Remove some unneeded boilerplate
Browse files Browse the repository at this point in the history
  • Loading branch information
mats-claassen committed Mar 27, 2024
1 parent cd2d503 commit 773cb3d
Show file tree
Hide file tree
Showing 30 changed files with 57 additions and 991 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ ENV FLIT_ROOT_INSTALL=1

COPY pyproject.toml .
RUN touch README.md \
&& mkdir -p src/python_package \
&& mkdir -p src/tf_tabular \
&& python -m flit install --only-deps --deps develop \
&& rm -r pyproject.toml README.md src
13 changes: 1 addition & 12 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,8 @@
"github.vscode-pull-request-github",
"ms-azuretools.vscode-docker",
"ms-python.python",
"ms-python.vscode-pylance",
"ms-python.pylint",
"ms-python.isort",
"ms-python.flake8",
"ms-python.black-formatter",
"ms-vsliveshare.vsliveshare",
"ryanluker.vscode-coverage-gutters",
"bungcip.better-toml",
"GitHub.copilot"
],
Expand All @@ -28,17 +23,11 @@
"black-formatter.path": [
"/usr/local/py-utils/bin/black"
],
"pylint.path": [
"/usr/local/py-utils/bin/pylint"
],
"flake8.path": [
"/usr/local/py-utils/bin/flake8"
],
"isort.path": [
"/usr/local/py-utils/bin/isort"
]
}
}
},
"onCreateCommand": "pre-commit install-hooks"
}
}
38 changes: 18 additions & 20 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,20 @@
version: 2
updates:
- package-ecosystem: pip
directory: "/"
schedule:
interval: daily
time: "13:00"
open-pull-requests-limit: 10
reviewers:
- dciborow
allow:
- dependency-type: direct
- dependency-type: indirect
commit-message:
prefix: "fix: "
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: daily
time: "13:00"
commit-message:
prefix: "fix: "
- package-ecosystem: pip
directory: "/"
schedule:
interval: daily
time: "07:00"
open-pull-requests-limit: 3
allow:
- dependency-type: direct
commit-message:
prefix: "update: "
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: daily
time: "07:00"
commit-message:
prefix: "update: "
open-pull-requests-limit: 3
21 changes: 0 additions & 21 deletions .github/template-sync.yml

This file was deleted.

17 changes: 0 additions & 17 deletions .github/workflows/semantic-pr-check.yml

This file was deleted.

18 changes: 0 additions & 18 deletions .github/workflows/sphinx.yml

This file was deleted.

12 changes: 0 additions & 12 deletions .github/workflows/template-sync.yml

This file was deleted.

52 changes: 14 additions & 38 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,44 +17,20 @@ repos:
- id: requirements-txt-fixer
- id: trailing-whitespace

- repo: https://github.com/PyCQA/isort
rev: 5.12.0
- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: v0.2.0
hooks:
- id: isort
args: ["-a", "from __future__ import annotations"]
# Run the linter.
- id: ruff
args: [--fix]
# Run the formatter.
- id: ruff-format

- repo: https://github.com/asottile/pyupgrade
rev: v2.31.0
- repo: https://github.com/pre-commit/mirrors-mypy
rev: "v1.8.0" # Use the sha / tag you want to point at
hooks:
- id: pyupgrade
args: [--py37-plus]

- repo: https://github.com/hadialqattan/pycln
rev: v1.2.5
hooks:
- id: pycln
args: [--config=pyproject.toml]
stages: [manual]

- repo: https://github.com/codespell-project/codespell
rev: v2.1.0
hooks:
- id: codespell

- repo: https://github.com/pre-commit/pygrep-hooks
rev: v1.9.0
hooks:
- id: python-check-blanket-noqa
- id: python-check-blanket-type-ignore
- id: python-no-log-warn
- id: python-no-eval
- id: python-use-type-annotations
- id: rst-backticks
- id: rst-directive-colons
- id: rst-inline-touching-normal

- repo: https://github.com/mgedmin/check-manifest
rev: "0.47"
hooks:
- id: check-manifest
stages: [manual]
- id: mypy
args: [--ignore-missing-imports]
additional_dependencies:
- "types-PyYAML"
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) Microsoft Corporation.
Copyright (c) Xmartlabs.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
21 changes: 19 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
# Python Project Template
# TF Tabular

### Feature Overview
* Create input layers based on lists of columns
* No model building or training: Build whatever you want on top
* Support custom embeddings
* Support attention for mixing sequence layers
* Support multi-hot categoricals
* Support computing vocab and normalization params?


### Competitor analysis
* DeepTables:
* This is for TensorFlow
* Broader scope: Includes model building and training
* Pytorch tabular:
* Only Pytorch
* Broader scope: Includes model building and training
* Not focused on recommenders (no support for multi-hot and sequence columns https://github.com/manujosephv/pytorch_tabular/issues/174)

This project is a template for creating Python projects that follows the Python Standards declared in PEP 621. It uses a pyproject.yaml file to configure the project and Flit to simplify the build process and publish to PyPI. Flit simplifies the build and packaging process for Python projects by eliminating the need for separate setup.py and setup.cfg files. With Flit, you can manage all relevant configurations within the pyproject.toml file, streamlining development and promoting maintainability by centralizing project metadata, dependencies, and build specifications in one place.

## Project Organization

Expand Down
41 changes: 0 additions & 41 deletions SECURITY.md

This file was deleted.

20 changes: 0 additions & 20 deletions docs/Makefile

This file was deleted.

67 changes: 0 additions & 67 deletions docs/conf.py

This file was deleted.

16 changes: 0 additions & 16 deletions docs/devcontainer.md

This file was deleted.

3 changes: 0 additions & 3 deletions docs/developer.md

This file was deleted.

Loading

0 comments on commit 773cb3d

Please sign in to comment.