Add support for a gauge function and metric to track the maximum number of devices permitted to connect to a Talaria instance. #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ChaitanyaSingla
changed the title
ChaitanyaSingla
changed the title
Sachin4403
approved these changes
Aug 12, 2024
johnabass
approved these changes
Oct 7, 2024
|
@ChaitanyaSingla you need to sign the CLA agreement in order for this to proceed. |
|
@ChaitanyaSingla you need to sign the CLA agreement in order for this to proceed. as @johnabass pointed out |
|
@johnabass @denopink I have already signed the CLA agreement, but it is still showing as pending. |
|
@ChaitanyaSingla can you sign it again? 🙂 |
|
@denopink Done. |
|
looks like it worked this time, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to introduce a metric in Talaria that reflects the maximum number of devices permitted to connect to a Talaria instance. This pull request includes the addition of a gauge function and a metric to monitor the maximum allowed device connections for Talaria.
Reference issue for this MR: xmidt-org/talaria#299
cc: @Sachin4403