patch: fix failing webpa-common tests #1055
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
denopink
commented
Oct 21, 2024
•
denopink
commented
- fix failing webpa-common tests
Hard-Coded Secrets (1)
More info on how to fix Hard-Coded Secrets in General. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
denopink
force-pushed
the
denopink/patch/ci-and-device_drain_tests
branch
from
137a120 to
7903139
Compare
- `TestDrainer` tests weren't well made, they led to a race-like condition where a slow running machine will fail some draining tests - fix metric registry_test.go tests (add default debugger logger)
denopink
force-pushed
the
denopink/patch/ci-and-device_drain_tests
branch
from
7903139 to
fc0d191
Compare
denopink
changed the title
TestDrainers tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.