Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum widths for Shrink and Expand #858

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

dcousens
Copy link
Contributor

@dcousens dcousens commented Dec 22, 2023

Description

I went to use the TwoPane layout while trying out xmonad, and immediately ran into the problem that Shrink and Expand were shrinking my windows into negative width, which broke alacritty.

To investigate the problem, I started reading the Layout.hs from xmonad/xmonad, and noticed that the Tall layout applies a min and max to the respective widths:

Applying this same approach to Shrink and Expand in the TwoPane layouts (tested in my own xmonad.hs) resolves this problem for me, but I am a beginner to xmonad and may be misunderstanding something. 💙

Checklist

  • I've read CONTRIBUTING.md

  • I've considered how to best test these changes (property, unit,
    manually, ...) and concluded: writing tests is probably beyond my spare time for now

  • I updated the CHANGES.md file

Copy link
Member

@slotThe slotThe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@slotThe slotThe merged commit 5ceaed8 into xmonad:master Dec 23, 2023
18 checks passed
@slotThe
Copy link
Member

slotThe commented Dec 23, 2023

Thank you 🎉

@dcousens dcousens deleted the fix-min-width branch December 23, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants