Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll to pages #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

comlaterra
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #24 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage    92.3%   92.39%   +0.08%     
==========================================
  Files           6        6              
  Lines         260      263       +3     
==========================================
+ Hits          240      243       +3     
  Misses         20       20
Impacted Files Coverage Δ
lib/src/pages.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b01c1...72d5a96. Read the comment docs.

@xsahil03x
Copy link
Owner

@comlaterra can you also please mention the issue which you are solving ?

@comlaterra
Copy link
Author

This is not necessarily an issue fix, but a new feature. ( despite in my case was )
With the previous version, if the content was longer than the container, an overflow was happening.
I believe that behaviour is not ideal, so I think is way better to enable the scroll in the container, so the content won't overflow.

@xsahil03x
Copy link
Owner

Nice catch 👍 will push it in the next release

@xsahil03x
Copy link
Owner

@comlaterra can you please remove merge conflicts?

@comlaterra
Copy link
Author

My apologies for not taking care of this earlier. Is this still relevant?
Should I still take care of the merge conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants