phase 7 production - #23
Conversation
1cb88e4 to
52ea16b
Compare
JavadManashti
left a comment
There was a problem hiding this comment.
Approving — content is solid and I verified the mechanical concerns rather than just flagging them.
Verified clean:
.cursor/skills/andskills/trees are byte-identical (onlyskills/README.mddiffers, correctly) — and theSync provider filesworkflow passed, so the duplication is automated, not manual drift.- All three webhook fixtures:
.raw.txtparses to exactly the same JSON as the pretty.json. The documentedshasum -a 1signature example will work against the raw bytes as written. - No broken relative markdown links repo-wide; no dangling refs to the removed
## Country Handlingsection inpayment-methods-list.md.
Non-blocking nits for a follow-up:
-
"Phase 7" now means two different things.
headless-checkout-integrationgainsPhase 7 — Payment country, whileshop-setupgainsPhase 7 — Production / go-live— and headless's own line 111 says "Production / go-live is Phase 7 ofshop-setup" immediately after declaring its own Phase 7. Each skill has its own sequence so it's defensible, but an agent reading both in one context could conflate them. Consider naming headless's asPhase 7 (checkout) — Payment countryor renumbering. -
status: draftvs README "Done".production/SKILL.mdfrontmatter saysstatus: draft, butREADME.mdandskills/README.mdlist it (plusheadless-checkout-integrationandwebhooks-impl) as Done. Every skill in the repo is stilldraftin frontmatter, so this is a pre-existing convention gap this PR widens — worth reconciling in one pass so the frontmatter is the single source of truth. -
Fixture data.
8.29.109.241inpayment.json/user_validation.jsonis a real routable address and reads like a capture of someone's actual IP.dry_run: 1/mode: "sandbox"confirm these are sandbox captures, so no live-money exposure, but since these ship as public example content I'd swap the IP for a documentation-range one (203.0.113.x, RFC 5737) and double-checkproject_id: 308077/merchant_id: 887981are throwaway sandbox IDs you're happy to publish.
Nothing above blocks the merge — the guidance itself is the strongest part of this PR. The payment-country.md IP-resolution table (especially the Fastly/Cloud Run egress-IP warning) and the "ask the developer how goods are granted rather than inventing an inventory" instruction in handler-and-reliability.md both target real failure modes agents hit today.
No description provided.