-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: First Line Parser #515
Open
szymonlopaciuk
wants to merge
31
commits into
xsuite:main
Choose a base branch
from
szymonlopaciuk:sequence_parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be re-enabled whenever necessary, but as it is it's polluting the standard output of the test session far beyond of what's reasonable. Signed-off-by: Szymon Łopaciuk <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build a first iteration of a fast parser for a MAD-X inspired sequence language, currently capable of storing and loading Lines and Multilines. The expressions are kept in place, close to their corresponding elements, as opposed to the way data is structured in json. As an example, here's a "FODO":
Twiss default, configs, and metadata can be included. The parser is build using Bison+Flex, which compiles the grammar into C files, which interface with the rest of the parser written in Cython. On a standard HL-LHC lattice the read speed is <1.5x the json loading speed, which is somehow a necessary slow down due to the fact that we need to convert the different data layout -- still further speedup opportunities exist.
This has only been tested with Xtrack so far, and an environment flag
XTRACK_TEST_XLD=1
can be switched on in order to make a JSON->XLD->JSON round-trip every time a json file is loaded. When run as part of the test suite this can be the first step to ensure we do not break things in the future, even though currently this is experimental.Checklist
Mandatory:
Optional: