Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and parametrize snapshots directory name #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade dependencies and parametrize snapshots directory name #81

wants to merge 3 commits into from

Conversation

rigelk
Copy link
Contributor

@rigelk rigelk commented Sep 21, 2018

resolves #76 #77 #73
closes #79 #78

note: I didn't touch the service worker because I think it ought to be written by hand, using the one produced as a template. But maybe I should parametrize it too?

@rigelk rigelk changed the title Upgrade dependencies and parametrize snapshots directory name WIP: Upgrade dependencies and parametrize snapshots directory name Sep 21, 2018
@xuset
Copy link
Owner

xuset commented Sep 22, 2018

The changes look good so far! Thanks for the PR!

I remember a while ago if dev dependencies were included in the package-lock.json then npm install <module> would also install the dev dependencies. Do you know if this is still the case?

@rigelk
Copy link
Contributor Author

rigelk commented Sep 24, 2018

@xuset sorry about the comment - I replied to the wrong project PR on mobile and that didn't go as expected :/

@rigelk
Copy link
Contributor Author

rigelk commented Sep 24, 2018

@xuset to answer your question, npm install installs both devDependencies and regular dependencies. But when one installs planktos - or any module - as part of their dependencies, only dependencies are taken into account, regardless of the package-lock's inclusion of devDependencies. At least that's what I get from here.

@rigelk rigelk changed the title WIP: Upgrade dependencies and parametrize snapshots directory name Upgrade dependencies and parametrize snapshots directory name Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 10 of node.js has been released
2 participants