Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DefaultPublicationWorkflow.java #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dafacede
Copy link

@dafacede dafacede commented Oct 8, 2015

Publish did not copy Attachments to the new Document and give an Exeption on the first try. Second try let publish the Document but without Attachments.

With this, it worked for me, Attachments were in the new Dokument after Publishing, no more exeptions. Its just copy/past from copyContentsToNewVersion, with minor changes. Im not a Coder at all, my first try in Java.

Please pull, so that we dont need to Add this with every Update. Thank you!

Publish did not copy Attachments to the new Document and give an Exeption on the first try. Second try let publish the Document but without Attachments. 

With this, it worked for me, Attachments were in the new Dokument after Publishing, no more exeptions. Its just copy/past from copyContentsToNewVersion, with minor changes. Im not a Coder at all, my first try in Java.
@lucaa
Copy link
Member

lucaa commented Oct 12, 2015

hmmm... what version is this issue reproducing on? The base version of XWiki I mean. If you could add a detailed bug report here for the issue you're fixing, it would help a lot http://jira.xwiki.org/browse/XAWORKFLOW . Thanks!

@dafacede
Copy link
Author

I have signed up and give the requested info's. Have also seen that this Bug was fixed in Xwiki 5.4. I also tried the API-Version 1.5, the Bug was also in there.

With the code i get no Errormessage and the pictures are in the published Document. But i cant say that the "3 way Copy" is needed. It seems a bit Complicated for me, but i usualy just write Batch-Files and not Java.

Von meinem iPad gesendet

Am 12.10.2015 um 10:17 schrieb Anca Luca [email protected]:

hmmm... what version is this issue reproducing on? The base version of XWiki I mean. If you could add a detailed bug report here for the issue you're fixing, it would help a lot http://jira.xwiki.org/browse/XAWORKFLOW . Thanks!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants