XCOMMONS-2349: Improve performance of AttributeFilter in HTMLCleaner

* Do not protect the call to XPathFactory.newInstance() as it seems thread-safe after all.
xwiki · Jan 14, 2022 · c81137d · c81137d
1 parent 0afe529
commit c81137d
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/...e/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/filter/AttributeFilter.java b/...e/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/filter/AttributeFilter.java
@@ -95,16 +95,12 @@ public void filter(Document document, Map<String, String> cleaningParameters)
             xPathFactory = (XPathFactory) executionContext.getProperty(XPathFactory.class.getName());
 
             if (xPathFactory == null) {
-                synchronized (XPathFactory.class) {
-                    xPathFactory = XPathFactory.newInstance();
-                }
+                xPathFactory = XPathFactory.newInstance();
                 executionContext.newProperty(XPathFactory.class.getName()).type(XPathFactory.class).inherited()
                     .nonNull().initial(xPathFactory).makeFinal().declare();
             }
         } else {
-            synchronized (XPathFactory.class) {
-                xPathFactory = XPathFactory.newInstance();
-            }
+            xPathFactory = XPathFactory.newInstance();
         }