XDOCKER-165: Add image for XWiki on MariaDB (docs) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a section for starting XWiki with MariaDB * Changes starting mariadb using name mariadb-xwiki * Used MARIADB_* environment variables for initialization of MariaDB container. * --character-set-server=utf8mb4 is the default in MariaDB container, omit for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for putting up a MariaDB based Docker Library official image. As the Docker Library maintainer for MariaDB I felt honoured to try it out.
The things I've changed in this PR are:
container.
omit for simplicity.
Things that might be unnecessary are:
/my/path/{mariadb,mysql}-init, both MySQL and MariaDB use the environment variables
MYSQL_USER,MYSQL_PASSWORD,MYSQL_DATABASEandMARIADB_*equivalents to createGRANT ALL on $MYSQL_DATABASE.* TO $MYSQL_USER@%. Is there some global privilege required?As xwiki (as far as I see) doesn't use the root password, perhaps using
MARIADB_RANDOM_ROOT_PASSWORD=1/MYSQL_RANDOM_ROOT_PASSWORD=1to hide its use from ordinary users.Collation - the setting to utf8_bin, is this a need for case sensitive collations?
You are welcome to use the container images from the pre-release in your CI to ensure that we don't regress anything in the server that affects xwiki - https://mariadb.org/new-service-quay-io-mariadb-foundation-mariadb-devel/.