XWIKI-18816: Useless and somewhat invalid <dt> markup on the login fo…

…rm (#3379) * Updated the DOM of the login form to be valid HTML (cherry picked from commit 30ab390)
xwiki · Oct 16, 2024 · 231a184 · 231a184
1 parent 9b80903
commit 231a184
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/...go-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/misc.less b/...go-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/misc.less
@@ -219,6 +219,8 @@ div.suggestItems .hide-button {
     display: flex;
     flex-flow: row wrap;
     gap: 1em;
+    /* Same as `.xform dl dt` */
+    margin-top: floor(@font-size-base * 1.4);
   }
 }
 

diff --git a/...flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/login.vm b/...flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/login.vm
@@ -85,19 +85,19 @@
       $supplementaryForm
     </div>
   #end
-  <dt class="submitSection">
-    <input type="submit" class="btn btn-primary col-xs-12" value="$escapetool.xml($services.localization.render('login'))"/>
+  </dl>
+<div class="submitSection">
+  <input type="submit" class="btn btn-primary col-xs-12" value="$escapetool.xml($services.localization.render('login'))"/>
 
-    #set ($forgotUsernameURL = $services.security.authentication.getAuthenticationURL('retrieveusername', $NULL))
-    #if("$!forgotUsernameURL" != "")
-      <span class="xAdditional"><a href="$forgotUsernameURL">$escapetool.xml($services.localization.render('xe.admin.forgotUsername.loginMessage'))</a></span>
-    #end
-    #set ($resetPasswordUrl = $services.security.authentication.getAuthenticationURL('resetpassword', $NULL))
-    #if("$!resetPasswordUrl" != '')
-      <span class="xAdditional recoverPassword"><a href="$resetPasswordUrl" >$escapetool.xml($services.localization.render('xe.admin.passwordReset.loginMessage'))</a></span>
-    #end
-  </dt>
-</dl>
+  #set ($forgotUsernameURL = $services.security.authentication.getAuthenticationURL('retrieveusername', $NULL))
+  #if("$!forgotUsernameURL" != "")
+    <span class="xAdditional"><a href="$forgotUsernameURL">$escapetool.xml($services.localization.render('xe.admin.forgotUsername.loginMessage'))</a></span>
+  #end
+  #set ($resetPasswordUrl = $services.security.authentication.getAuthenticationURL('resetpassword', $NULL))
+  #if("$!resetPasswordUrl" != '')
+    <span class="xAdditional recoverPassword"><a href="$resetPasswordUrl" >$escapetool.xml($services.localization.render('xe.admin.passwordReset.loginMessage'))</a></span>
+  #end
+</div>
 #xwikimessageboxend()
 </form>
 </main>## mainContentArea