XWIKI-13967: Confusion between Supported Languages and Default Languages when multilingual is set to no #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges when multilingual is set to no * Added a CSS ruleset to remove the supported languages field from the UI when it's not useful.
surli
approved these changes
Jan 8, 2024
manuelleduc
approved these changes
Jan 18, 2024
|
Out of curiosity, why do you need those options in the maven command: |
tmortagne
approved these changes
Jan 18, 2024
|
surli
added
the
backport stable-15.10.x
surli
pushed a commit
that referenced
this pull request
Jan 18, 2024
…ges when multilingual is set to no (#2770) (#2805) * Added a CSS ruleset to remove the supported languages field from the UI when it's not useful. (cherry picked from commit fcb4699) Co-authored-by: C. Lucas <[email protected]>
Sereza7
added a commit
to Sereza7/xwiki-platform
that referenced
this pull request
Jan 18, 2024
…ges when multilingual is set to no (xwiki#2770) * Added a CSS ruleset to remove the supported languages field from the UI when it's not useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://jira.xwiki.org/browse/XWIKI-13967
PR Changes
Note
This makes use of the new CSS feature
:has, which is only available in the latest stable release of Firefox. For now this release is not used by all users but in less than 30 days we can count on 70% of users moving on this version. All of the other supported browser for XWiki have supported:hasfor a while. It's a correct change in regards to our browser support policy.<EDIT> On older versions of Firefox, the rule is ignored and the supported language field is always shown. </EDIT>
View
Here is a demo of the changes brought in this PR. We can see that the
support languagesfield disappears when the wiki is not set as multilingual.Tests
Successfully passed
mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker -Dxwiki.enforcer.skip=true -Dgradle.cache.local.enabled=false -Dgradle.cache.remote.enabled=false.