Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21772: Admin section: make user directory pass webstandard tests #2795

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jan 16, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21772

Changes

Description

  • Fixed the input label validation to allow another standard HTML way to link the label to its input.
  • Removed the comment from the test for WYSIWYG

Clarifications

Executed Tests

  • Successfully passed mvn clean install -f xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards

Expected merging strategy

  • Prefers squash: Yes
  • Only on master.

Sereza7 and others added 3 commits January 12, 2024 16:09
* Fixed the input label validation to allow another standard HTML way to link the label to its input.

Note: This allowed the user directory to pass webstandard tests properly, but did not fix other pages (at least not completely)
* Removed the comment from the test for WYSIWYG
@surli surli merged commit 1c596ea into xwiki:master Feb 12, 2024
Sereza7 added a commit to Sereza7/xwiki-platform that referenced this pull request Feb 12, 2024
xwiki#2795)

* Fixed the input label validation to allow another standard HTML way to link the label to its in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants