XWIKI-21763: Disable the server-side image resizing while exporting to PDF #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o PDF * Modify the default and all configuration sources to check the execution context source first. * Split PDFExportJob in "two" to reduce ClassFanOut complexity * Update test content to resize image on the server-side (in view mode) * Enable the image processing plugin while running the tests to have the server-side image resize enabled in view mode.
manuelleduc
reviewed
Feb 1, 2024
| /** | ||
| * Base class for PDF export job. | ||
| * | ||
| * @version $Id$ |
manuelleduc
reviewed
Feb 1, 2024
| @Override | ||
| public JobGroupPath getGroupPath() | ||
| { | ||
| return new JobGroupPath(Arrays.asList("export", "pdf")); |
There was a problem hiding this comment.
If you want a shorter version (and based on Java standard APIs).
Suggested change
| return new JobGroupPath(Arrays.asList("export", "pdf")); | |
| return new JobGroupPath(List.of("export", "pdf")); |
manuelleduc
reviewed
Feb 1, 2024
| * | ||
| * @version $Id$ | ||
| */ | ||
| public abstract class AbstractPDFExportJob extends AbstractJob<PDFExportJobRequest, PDFExportJobStatus> |
There was a problem hiding this comment.
I think moving the rendering part of the Job to an internal component that you can then inject is a better way to fix the ClassFanOutcheck than moving to an abstract class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21763
Changes
Description