Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21851: Found page in the Page Tree macro with a Solr field cannot be opened by left-clicking #2866

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Feb 8, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21851

Changes

Description

  • Updated the default option (introduced in JSTree 3.3.16) to allow reactivation of a link that's already selected.

Screenshots & Video

Video demo

Executed Tests

Properly passed mvn clean install -amd -f xwiki-platform-core/xwiki-platform-tree -pl :xwiki-platform-tree-webjar -Pquality,integration-tests,docker after updating the .pom with the correct version of jstree.
Manual tests were conducted and did end up successful, see video demo. I had some issues getting my local distribution to get the updated jar, in the end I realized it was pulling it from cache...

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.X (regression introduced when updating to jstree 3.3.15 in 15.2-rc1)

…ot be opened by left-clicking

* Updated the default option to allow reactivation of a link that's already selected.
@Sereza7 Sereza7 marked this pull request as ready for review February 9, 2024 10:59
@Sereza7 Sereza7 added the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label Feb 9, 2024
@surli surli merged commit 6a7beb3 into xwiki:master Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants