Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21848: Migrate NotificationFilterPreferenceLivetableResults to a Live Data source #2971

Merged
merged 25 commits into from
Mar 20, 2024

Conversation

surli
Copy link
Member

@surli surli commented Mar 7, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21848

Changes

Description

  • Provide 2 different LD custom source: one for Custom Filter Preferences and one for System Filter Preferences: the reason for not going to a single LD source is that those LT are now very different and we use to hack the data source to provide different information. Having 2 different sources make things very more clear
  • Provide ordering / filtering on the Custom Filter source as it's the one with most entries
  • Don't provide any kind of ordering / filtering for System filter preferences: in XS we only have 6 items, and it's rare to have custom filters
  • Provide some new APIs where needed

WIP:

  •  need to fix enabling / disabling system filters
  • Really remove the old NotificationFilterPreferenceLivetableResults
  • Fix doc
  • Fix checkstyle
  • Fix bug with boolean filter displaying translation keys
  • Fix coverage
  • Deprecate some translations
  • Check tests
  • Run integration tests with other DBs
  • Manual tests on subwiki and local users in subwiki
  • Scenario to test: add custom filter for an event type coming from an extension and then uninstall the extension
  • Provide integration tests
  • Fix since
  • Check cards layout
  • Ensure to have a default order for custom filters (sort by ID)

Clarifications

Screenshots & Video

System filters:
image

Custom filters:
image

Executed Tests

  • All integration tests of xwiki-platform-notification-test-docker also run with database mysql
  • Ran manual checks of the live data in main wiki and subwiki with global and local users and also with wikis administration
  • Played with filtering / sorting / enabling / disabling / deleting / creating
  • Tried combination of filtering and pagination (> 300 filters)

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None

@surli surli force-pushed the custom-ld-source-notif-filters branch from 4b599fc to 6dc15b1 Compare March 13, 2024 10:52
surli and others added 18 commits March 14, 2024 15:22
…a Live Data source

  * Improve work after Manuel's review
  * Provide some helpers to factorize code and provide better SoC
  * Use a dedicated StaticList displayer

Co-Authored-By: Manuel Leduc <[email protected]>
…a Live Data source

  * Mark one of the translation as deprecated
…a Live Data source

  * Fix bad translations for enabled filter
…a Live Data source

  * Rollback changes from previous commit as it apparently doesn't
    work...
  * Fix issue with sort of scope
…a Live Data source

  * Improve a bit the code of NotificationSystemFiltersLiveDataEntryStore
  * Start adding tests
@surli surli force-pushed the custom-ld-source-notif-filters branch from 3c31545 to 175afe2 Compare March 14, 2024 14:22
…a Live Data source

  * Provide new unit test
  * Add equals/toString methods in DefaultQueryParameter
  * Provide new unit test in module query-manager to fix coverage
…a Live Data source

  * Improve a bit the unit test
…a Live Data source

  * Provide more unit tests
@surli surli marked this pull request as ready for review March 18, 2024 16:12
…a Live Data source

  * Fix since values
  * Introduce integration tests
  * Introduce page objects for LiveData panels
  * Fix UserProfile PO to allow following user
@surli surli force-pushed the custom-ld-source-notif-filters branch from 02cc7cb to ee34d32 Compare March 20, 2024 13:12
@surli surli merged commit c376fa9 into master Mar 20, 2024
1 check passed
@surli surli deleted the custom-ld-source-notif-filters branch March 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants