-
-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWIKI-21848: Migrate NotificationFilterPreferenceLivetableResults to a Live Data source #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelleduc
reviewed
Mar 8, 2024
...src/main/java/org/xwiki/notifications/filters/internal/DefaultNotificationFilterManager.java
Outdated
Show resolved
Hide resolved
surli
force-pushed
the
custom-ld-source-notif-filters
branch
from
March 13, 2024 10:52
4b599fc
to
6dc15b1
Compare
…a Live Data source WIP
…a Live Data source WIP
…a Live Data source WIP
…a Live Data source
…a Live Data source
…a Live Data source
…a Live Data source
…a Live Data source
…a Live Data source
…a Live Data source
…a Live Data source
…a Live Data source * Improve work after Manuel's review * Provide some helpers to factorize code and provide better SoC * Use a dedicated StaticList displayer Co-Authored-By: Manuel Leduc <[email protected]>
…a Live Data source * Fix some bugs
…a Live Data source * Fix some other bugs
…a Live Data source * Mark one of the translation as deprecated
…a Live Data source * Fix bad translations for enabled filter
…a Live Data source * Rollback changes from previous commit as it apparently doesn't work... * Fix issue with sort of scope
…a Live Data source * Improve a bit the code of NotificationSystemFiltersLiveDataEntryStore * Start adding tests
surli
force-pushed
the
custom-ld-source-notif-filters
branch
from
March 14, 2024 14:22
3c31545
to
175afe2
Compare
…a Live Data source * Provide a few tests
…a Live Data source * Provide new unit test * Add equals/toString methods in DefaultQueryParameter * Provide new unit test in module query-manager to fix coverage
…a Live Data source * Improve a bit the unit test
…a Live Data source * Provide more unit tests
…a Live Data source * Fix since values * Introduce integration tests * Introduce page objects for LiveData panels * Fix UserProfile PO to allow following user
surli
force-pushed
the
custom-ld-source-notif-filters
branch
from
March 20, 2024 13:12
02cc7cb
to
ee34d32
Compare
…a Live Data source * Sort by filter identifier by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21848
Changes
Description
WIP:
Clarifications
Screenshots & Video
System filters:
Custom filters:
Executed Tests
Expected merging strategy