XWIKI-21811: Don't display in logs Errors related to ObjectEvaluator when upgrading XWiki #2977
Conversation
…when upgrading XWiki
michitux
added
the
backport stable-15.10.x
| <script src="${services.webjars.url('org.xwiki.platform:xwiki-platform-search-webjar', 'searchSuggest.min.js', {'evaluate': true, 'h': $searchSuggestConfigHash.hashCode()})}" defer="defer"></script> | ||
| $xwiki.linkx.use( | ||
| $services.webjars.url('org.xwiki.platform:xwiki-platform-search-webjar', 'searchSuggest.min.css', {'evaluate': true}), | ||
| {'type': 'text/css', 'rel': 'stylesheet'})## |
There was a problem hiding this comment.
Hmmm couldn't it be considered as a possible breakage? Isn't it possible that an extension used to use that searchSuggest.js or css?
There was a problem hiding this comment.
It's not very clear if everything in uicomponents/ is supposed to be an API or not. I searched a bit in xwiki.org and could not find any documentation suggesting to use searchSuggest files, so I assumed it was OK enough as it's definitely not the first file we move from there to a webjar.
WDYT @mflorea ?
There was a problem hiding this comment.
Although it's not documented as an API we could have extensions that manually load this JavaScript/CSS. Adding a mention in the release notes (in the migration section) should be enough IMO.
...xwiki-platform-realtime/xwiki-platform-realtime-wiki/xwiki-platform-realtime-wiki-ui/pom.xml
Outdated
Show resolved
Hide resolved
...re/xwiki-platform-search/xwiki-platform-search-ui/src/main/resources/Main/DatabaseSearch.xml
Outdated
Show resolved
Hide resolved
xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-webjar/pom.xml
Show resolved
Hide resolved
...amingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/javascript.vm
Outdated
Show resolved
Hide resolved
| <script src="${services.webjars.url('org.xwiki.platform:xwiki-platform-search-webjar', 'searchSuggest.min.js', {'evaluate': true, 'h': $searchSuggestConfigHash.hashCode()})}" defer="defer"></script> | ||
| $xwiki.linkx.use( | ||
| $services.webjars.url('org.xwiki.platform:xwiki-platform-search-webjar', 'searchSuggest.min.css', {'evaluate': true}), | ||
| {'type': 'text/css', 'rel': 'stylesheet'})## |
There was a problem hiding this comment.
Although it's not documented as an API we could have extensions that manually load this JavaScript/CSS. Adding a mention in the release notes (in the migration section) should be enough IMO.
…when upgrading XWiki * Fix wrong dependencies * Improve code style
…when upgrading XWiki * Target version 16.3.0-SNAPSHOT
Jira URL
https://jira.xwiki.org/browse/XWIKI-21811
Changes
Description
SearchSuggestSourceObjectEvaluator.Clarifications
This PR moves the UI component
searchSuggest.jsto its own module with the proper dependencies.It also refactors the different places that relied on the newly moved files.
Screenshots & Video
N/A
Executed Tests
The update process was run successfully with this patch and the errors are no longer logged.
The search suggestions still work as expected.
Expected merging strategy