XWIKI-22577: Cloning documents with many XObjects and high object numbers is slow #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmortagne
force-pushed
the
feature-XWIKI-22577
branch
from
a087017
to
a76eeb9
Compare
surli
reviewed
Oct 25, 2024
| return 1; | ||
| } | ||
|
|
||
| if (value.getClass() == otherValue.getClass() && value instanceof Comparable comparableValue) { |
There was a problem hiding this comment.
Just a minor comment but I think the construct value instanceof Comparable comparableValue is more recent than java 11 and so cannot be backported to 15.10.x as it is.
There was a problem hiding this comment.
Yes indeed. I'd better make sure to use a Java 11 compatible code for now.
tmortagne
force-pushed
the
feature-XWIKI-22577
branch
from
a76eeb9
to
704e1b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22577
Changes
Description
Trying to speed up the xobjects part of the document cloning.
Clarifications
Executed Tests
Not really any new test, since xobject cloning is well covered already, and it's not easy to test performances through automated testing.
Expected merging strategy