XWIKI-12987: Relative links are made absolute or even broken after moving a page #3634

…ving a page WIP The idea of this work is to: 1. Provide a way to access all documents that are moved as part of a move job 2. Use that information when performing a call to ReferenceRenamer to define if a relative untyped link should be handled or not On top of it, the idea is also to check if the doc exists in case of refactoring of a link to avoid refactoring unexisting relative links. One problem is remaining about relative link pointing to sibling pages (e.g. the link to Alice in Bob page in the ticket): we rely apparently to an old mechanism for backward compatibility reason for this to work in the UI, we might need same thing in the check, or to decide to ignore that UC. I started to add an integration tests but for some reason it's not passing, though it seemed to be working locally for the scenario described in the ticket (except for the link in Bob page).

…ving a page * Fix integration test setup * Fix some signatures * Work on the conditions for performing link update: WIP

…ving a page * Fix conditions to make all RenamePageIT passing * WIP: need to double check that some conditions are not redundant and double check side effects

…ving a page * Simplify a bit the conditions in ResourceReferenceRenamer and ensure all unit tests are passing in refactoring module

…ving a page * Fix checkstyle * WIP: try to find proper oracle for renaming absolute references, without success so far.

…ving a page * Find proper conditions to perform or not link renames * Fix unit tests to add missing conditions * WIP: need to fix coverage and check on subwikis / with more conditions (e.g. with holes in hierarchy)

…ving a page * Fix a regression and provide a test to cover it

…ving a page * Provide subwiki integration tests * Minor improvment in RenamePageIT

…ving a page * Improve SubWikiIT to add more checks

…ving a page * Few improvments following review

…ving a page * Change APIs to use a Map<EntityReference, EntityReference> corresponding to the source and target of refactorings in renamers * Change some logic of AbstractCopyOrMoveJob to compute the actual couple source/destination before performing any operation and store the info in EntitySelection * Add a log in RenameJob if it's not executed because of the number of entities (not needed for this issue, but felt better to understand what's happening)

…ving a page * Fix remaining coverage problems

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XWIKI-12987: Relative links are made absolute or even broken after moving a page #3634

XWIKI-12987: Relative links are made absolute or even broken after moving a page #3634

Commits on Nov 12, 2024