XRENDERING-619: Lists with nested paragraphs are incorrectly converted to XWiki syntax #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to XWiki syntax * Add an integration test to test the behavior * Make the detection of first element rendered more robust.
tmortagne
reviewed
Jun 14, 2024
| Paragraph 5 | ||
|
|
||
| 1. Paragraph 5.1 | ||
| 11. Paragraph 5.1.1((( |
There was a problem hiding this comment.
It's a bit surprising to have a different result between text followed by a list and text followed by a paragraph, but that's a xhtml parser thing, so not really related to the target of this pull request.
tmortagne
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XRENDERING-619
Changes
Description
Clarifications
Screenshots & Video
Executed Tests
in
xwiki-rendering.Expected merging strategy