fix golangci-lint

cmd/manssh/actions.go

@@ -130,7 +130,9 @@ func backupCmd(c *cli.Context) error {
 		return printErrorWithHelp(c, err)
 	}
 	backupPath := c.Args().First()
-	os.MkdirAll(backupPath, os.ModePerm)
+	if err := os.MkdirAll(backupPath, os.ModePerm); err != nil {
+		return cli.NewExitError(err, 1)
+	}
 
 	paths, err := manssh.GetFilePaths(path)
 	if err != nil {
@@ -141,7 +143,9 @@ func backupCmd(c *cli.Context) error {
 		bp := backupPath
 		if p != path && strings.HasPrefix(p, pathDir) {
 			bp = filepath.Join(bp, strings.Replace(p, pathDir, "", 1))
-			os.MkdirAll(filepath.Dir(bp), os.ModePerm)
+			if err := os.MkdirAll(filepath.Dir(bp), os.ModePerm); err != nil {
+				return cli.NewExitError(err, 1)
+			}
 		}
 		if err := exec.Command("cp", p, bp).Run(); err != nil {
 			return cli.NewExitError(err, 1)

cmd/manssh/kv_flag.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"encoding/json"
 	"fmt"
 	"strings"
 )
@@ -30,6 +29,10 @@ func (kv *kvFlag) String() string {
 	if kv == nil {
 		return ""
 	}
-	jsonBytes, _ := json.Marshal(kv)
-	return string(jsonBytes)
+
+	item := make([]string, len(kv.m))
+	for k, v := range kv.m {
+		item = append(item, k+"="+v)
+	}
+	return strings.Join(item, ",")
 }

cmd/manssh/main.go

@@ -2,9 +2,11 @@ package main
 
 import (
 	"fmt"
+	"log"
 	"os"
 
 	"github.com/urfave/cli"
+
 	"github.com/xwjdsh/manssh/utils"
 )
 
@@ -18,7 +20,9 @@ func main() {
 	app.Version = version
 	app.Flags = flags()
 	app.Commands = commands()
-	app.Run(os.Args)
+	if err := app.Run(os.Args); err != nil {
+		log.Fatal(err)
+	}
 }
 
 func flags() []cli.Flag {

cmd/manssh/print.go

@@ -13,7 +13,9 @@ import (
 )
 
 func printErrorWithHelp(c *cli.Context, err error) error {
-	cli.ShowSubcommandHelp(c)
+	if err := cli.ShowSubcommandHelp(c); err != nil {
+		return err
+	}
 	fmt.Println()
 	return cli.NewExitError(err, 1)
 }

manssh.go

@@ -243,7 +243,9 @@ func Add(p string, ao *AddOption) (*HostConfig, error) {
 		Patterns: []*ssh_config.Pattern{pattern},
 		Nodes:    nodes,
 	})
-	writeConfig(ao.Path, cfg)
+	if err := writeConfig(ao.Path, cfg); err != nil {
+		return nil, err
+	}
 
 	_, aliasMap, err = parseConfig(p)
 	if err != nil {

manssh_test.go

@@ -65,8 +65,8 @@ var (
 )
 
 func initConfig() {
-	os.MkdirAll(configRootDir, os.ModePerm)
-	os.MkdirAll(filepath.Join(configRootDir, "config.d"), os.ModePerm)
+	_ = os.MkdirAll(configRootDir, os.ModePerm)
+	_ = os.MkdirAll(filepath.Join(configRootDir, "config.d"), os.ModePerm)
 	if err := ioutil.WriteFile(mainConfigPath, []byte(fmt.Sprintf(mainConfigContent, configRootDir)), 0644); err != nil {
 		panic(err)
 	}
@@ -109,12 +109,14 @@ func TestList(t *testing.T) {
 	hosts, err = List(mainConfigPath, ListOption{
 		Keywords: []string{"Test"},
 	})
+	require.Nil(t, err)
 	require.Equal(t, 1, len(hosts))
 
 	hosts, err = List(mainConfigPath, ListOption{
 		Keywords:   []string{"Test"},
 		IgnoreCase: true,
 	})
+	require.Nil(t, err)
 	require.Equal(t, 3, len(hosts))
 }