Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Separated bar background into it's own Xresource. #386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jakem72360
Copy link

Added the ability to set text color in the bar separately using it's own Xresource. This is because some background/foreground combinations do not provide enough contrast for text-readability.

@jakem72360 jakem72360 changed the title Separated text color into it's own Xresource. Separated bar background into it's own Xresource. Feb 12, 2020
@jakem72360
Copy link
Author

Changed the new option to change the bar background, as the highlights/marks were still unreadable. Apologies for a misleading PR :/

@N-R-K
Copy link

N-R-K commented Aug 4, 2021

Seems like pull requests aren't being accepted anymore. But should be worth pointing out that

bbg = win_res(db, RES_CLASS ".barBackground", "white");

this will break experience for existing users. Better to use fg as a fallback instead of "white" so it stays consistent with previous behavior. It also makes more sense to add barForegound as well.

This is currently what I have on my build: https://dpaste.com/736HJ6J6K

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants