-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FullText Search in laravel-oci8 #800
Open
jonas-elias
wants to merge
21
commits into
yajra:10.x
Choose a base branch
from
jonas-elias:jonas-elias_where-full-text
base: 10.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
de9568e
feat: whereFullText query grammar
jonas-elias 5b76c5b
feat: compileFullText index schema grammar
jonas-elias 042cfc8
feat-test: whereFullText query
jonas-elias bbe901e
feat-test: create index fullText in schema
jonas-elias a36b316
fix-test: change name statement whereFullText
jonas-elias 30523ef
fix: styleci integration yajra/laravel-oci8
jonas-elias 505cd8e
fix: grammar whereFullText multiple parameters with logical operator
jonas-elias bde355e
fix-test: whereFullText with single and multiple parameters
jonas-elias 1a30ba6
fix: styleci integration yajra/laravel-oci8
jonas-elias e796371
fix: removed of contains() oracle method
jonas-elias 6107157
feat-test: orWhereFullText added in query grammar tests
jonas-elias d14b070
fix: labelSearch auto increment in contains() oracle feat
jonas-elias 84d4562
fix-test: third parameter in contains() oracle feat
jonas-elias e218712
fix: style integration yajra/laravel-oci8
jonas-elias abac01e
fix-style: integration yajra/laravel-oci8
jonas-elias 7588aff
feat: oracle ctx_ddl preferences implemented
jonas-elias 6fafdc1
feat-test: oracle ctx_ddl preferences tests
jonas-elias da97695
fix-test: dropFullText items single and multiples
jonas-elias 61bdcfd
feat: dropFullText method implemented && fix fullText create single a…
jonas-elias 5fb284a
feat: ctxDdlPreferences attribute created to call modifications commands
jonas-elias 8272ef4
fix-ci: style yajra/laravel-oci8
jonas-elias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQL generated is as expected but doesn't work when executed on actual DB migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg.. multiple columns index in oracle is implemented with ctx_ddl preferences 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, ctx_ddl is something new to me 😅. Do I need some special setup for this work?
Will also try to research this. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is new for me too 😅, but i researched about this, is simple to use.
For create multiple columns index, is necessary execute grant CTX_DDL to owner.
The code create preference "idx" and set configuration for columns "FIRSTNAME" and "LASTNAME", attribuiting in creation of index "firstname_multiple":
Is possible search if content contains in column "LASTNAME" by:
SELECT * FROM USERS u WHERE CONTAINS(FIRSTNAME, 'content_lastname') > 0
Summarized implementation of multiple full text index columns in oracle 😎
References:
https://docs.oracle.com/en/database/oracle/oracle-database/19/ccref/CTX_DDL-package.html#GUID-0F7C39E8-E44A-421C-B40D-3B3578B507E9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this bug and implemented ctx_ddl preferences to create multi_columns_index oracle feature. In method compileFullText(), i implemented one index to each column, enabling the search of multi column preference. If you have any suggestions, don't hesitate to help me 😅. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hpacleb, you have a new suggestions? 😁