Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update search and contributors CI #435

Closed
wants to merge 3 commits into from

Conversation

illionillion
Copy link
Member

Closes #434

Description

Current behavior (updates)

New behavior

Is this a breaking change (Yes/No):

Additional Information

Copy link

vercel bot commented Aug 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yamada-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 7:31am

taroj1205
taroj1205 previously approved these changes Aug 20, 2024
Copy link
Member

@taroj1205 taroj1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirotomoyamada hirotomoyamada added the merge request Request approval from codeowners label Aug 20, 2024
delete-branch: true
commit-message: "ci: updated search and contributors"
title: "Updated search and contributors"
branch: changeset-release/main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to one of the following candidate branch names.

  • chore/contributors
  • build/contributors
  • ci/contributors

@hirotomoyamada hirotomoyamada dismissed taroj1205’s stale review September 8, 2024 07:03

Reviews not enough.

@hirotomoyamada hirotomoyamada removed the merge request Request approval from codeowners label Sep 8, 2024
@hirotomoyamada
Copy link
Member

@illionillion @taroj1205

Hi, thanks for the PR.

This workflow will not run if you change meta.json.
Also, it is too impractical to run every time it is pushed to main.

@hirotomoyamada hirotomoyamada removed the review wanted Need review label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a CI that runs search and contributors.
3 participants