Add city hash as default hash function for balancer states #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevzman
changed the title
dataplane/hashtable.h
Outdated
| @@ -2389,7 +2396,7 @@ class hashtable_mod_spinlock | |||
| template<typename key_t, | |||
| typename value_t, | |||
| uint32_t chunk_size, | |||
| hash_function_t<key_t> calculate_hash = calculate_hash_crc<key_t>> | |||
| hash_function_t<key_t> calculate_hash = calculate_hash_city<key_t>> | |||
There was a problem hiding this comment.
Let us start with balancer sessions table only
yevzman
force-pushed
the
add-city-hash
branch
2 times, most recently
from
30bbc23 to
0e36f44
Compare
ol-imorozko
requested changes
Apr 9, 2024
| template<typename key_t> | ||
| inline uint32_t calculate_hash_city(const key_t& key) | ||
| { | ||
| return CityHash32((char*)&key, sizeof(key)); |
There was a problem hiding this comment.
reinterpret_cast<const char*>(&key)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.