Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement Support for Enhanced ACL Counters #164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saushew
Copy link
Collaborator

@saushew saushew commented Apr 11, 2024

This pull request aims to enhance YANET's ACL counters feature by implementing support for a new type of rule syntax inspired by IPFW. The proposed enhancement allows for more accurate tracking of active rules by associating counters with specific rule entries.

The current implementation of ACL counters in YANET has a notable limitation where intersecting rules may lead to false positive conclusions about rule activity. This limitation arises due to the top-down packet firewall rule lookup process, where only the counter of the terminating rule is incremented.

To address this issue, this pull request introduces support for rules of the form add count:counter_name, allowing administrators to specify a counter name associated with each rule. By associating counters directly with rules, we ensure that counters accurately reflect rule activity, even in cases of rule intersections.

Key Changes:

  • Introduce new rule syntax: add count:counter_name
  • Update rule processing logic to support associated counters
  • Implement necessary adjustments to maintain compatibility with existing rule sets

@ol-imorozko
Copy link
Collaborator

I don't know if we do this, but could you add this description to commit message too?

@GeorgyKirichenko
Copy link
Collaborator

I like the idea of tagging dumps and customizable counters but there are some points about:

  • I think that colon symbol does not fit well into ipfw syntax despite the fact that we agreed to extend them
  • We working on generalization of non-terminating rule processing (like dump, log, count, check-state, timeouts and others)

So let us to set the PR on hold at least until the non-terminating rules design makes clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants