padding of first convolution set to dilation in residualblock#62
Closed
ParsaEsmati wants to merge 1 commit intoyang-song:mainfrom
Closed
padding of first convolution set to dilation in residualblock#62ParsaEsmati wants to merge 1 commit intoyang-song:mainfrom
ParsaEsmati wants to merge 1 commit intoyang-song:mainfrom
Conversation
…e dilation>0 to avoid downsampling 2*dilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where downsampling is true and dilation>1 there are two convolutions both of which are downsampling by the number of dilation. However the shortcut is only downsampled with one dilation which creates a missmatch between shortcut and output when downsampling is true and dilation>1.
This fix sets the padding=dilation for the first convolution of the ResidualBlock in the case with downsampling 'true' and dilation>1.