-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy kubeconform to /usr/bin/kubeconform #145
base: master
Are you sure you want to change the base?
Conversation
Copy kubeconform directory to a directory that's in your PATH to avoid "kubeconform command not found" errors.
May I hint that For self-compiled programs |
I agree /usr/local/bin is probably the way to go, but I'm not sure if this is likely to break people's workflow, since some might have had to hardcode the path 🤔 |
@yannh I don't think this is gonna cause big issues. A note can be added in release notes. Also updating the location is a pretty simple job to do anyway. |
@@ -8,5 +8,5 @@ LABEL org.opencontainers.image.authors="[email protected]" \ | |||
org.opencontainers.image.url="https://github.com/yannh/kubeconform/" | |||
MAINTAINER Yann HAMON <[email protected]> | |||
RUN apk add ca-certificates | |||
COPY kubeconform / | |||
ENTRYPOINT ["/kubeconform"] | |||
COPY kubeconform ./usr/bin/kubeconform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest making it to:
COPY kubeconform /usr/local/bin/kubeconform
I am still concerned this might break people's workflow. Would there be a way with Symlinks to guarantee backward compatibility? |
Good idea. |
May I suggest marking the symlink deprecated for the (over) next major version bump? This way you'll provide backward compatibility while marking it as depreaction / breaking change at the same time and everyone has enough time to upgrade. |
Copy kubeconform directory to a directory that's in your PATH to avoid "kubeconform command not found" errors, e.g. issue #144. The kubeconform command should work now and be consistent with the instructions, instead of needing /kubeconform.