fix: prefer module.isBuiltin
when checking core modules
#152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
pkg
usesmodule.builtinModules
for checking core modules, while stripping anynode:
prefix. The problem is, certain core modules do not appear inbuiltinModules
and can only be checked withmodule.isBuiltin
. An example would benode:sqlite
(note: this is a prefix-only module, which must be imported with the prefix intact). I came across this when trying to package my project that usesundici
, which importsnode:sqlite
. Simplest way to illustrate this:Running:
will throw:
This PR fixes this by using
module.isBuiltin
if available.