Make compatible with Glimmer 2 #37
Conversation
Moves the element back into it's original parent so Glimmer 2's clean up code doesn't error out.
|
Does this seem like a good approach @krisselden @chrislopresto ? |
|
Lot's of people are going to have issues with this since ember 2.10.0 was released today. Any way I can help? |
|
The limitation that @rwjblue explained for ember-wormhole applies to ember-tether, too. Details here: yapplabs/ember-wormhole#66 (comment) |
|
Anyone know what's keeping this from being accepted an merged in? |
|
@tomoguisuru, probably the conflicting file. I'd love to see this get merged in as well. It's been over a month :| |
|
Hi @scottmessinger, @tomoguisuru, et al., I've been using ember-tether successfully with 2.10+ so while I'm not opposed to making this change, it would be best if it had a test associated with it that failed under Glimmer 2 so I understand what is being fixed. In addition, this PR is failing the build, so we need existing tests to be passing before this PR is mergeable. |
|
Any updates on this? |
|
My comment from January 2017 still stands. |
|
Closing due to no reproduction of the issue being addressed by this PR. |
Moves the element back into it's original parent so Glimmer 2's clean up code doesn't error out. Fixes #35