Skip to content

Commit

Permalink
Merge pull request #100 from btecu/master
Browse files Browse the repository at this point in the history
Update ember-cli and dependencies. Use ember modules.
  • Loading branch information
lukemelia authored Nov 12, 2017
2 parents 6992bb2 + 4670c87 commit adece04
Show file tree
Hide file tree
Showing 9 changed files with 618 additions and 522 deletions.
3 changes: 2 additions & 1 deletion addon/components/ember-wormhole.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { alias } from '@ember/object/computed';
import Component from '@ember/component';
import { observer, computed } from '@ember/object';
import { run } from '@ember/runloop';
Expand All @@ -14,7 +15,7 @@ export default Component.extend({
/*
* Attrs
*/
to: computed.alias('destinationElementId'),
to: alias('destinationElementId'),
destinationElementId: null,
destinationElement: computed('destinationElementId', 'renderInPlace', function() {
let renderInPlace = this.get('renderInPlace');
Expand Down
2 changes: 2 additions & 0 deletions ember-cli-build.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/* eslint-env node */
'use strict';

const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');

module.exports = function(defaults) {
Expand Down
4 changes: 2 additions & 2 deletions fastboot-tests/fixtures/fastboot/app/router.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Ember from 'ember';
import EmberRouter from '@ember/routing/router';
import config from './config/environment';

const Router = Ember.Router.extend({
const Router = EmberRouter.extend({
location: config.locationType,
rootURL: config.rootURL
});
Expand Down
40 changes: 19 additions & 21 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,51 +2,49 @@
"name": "ember-wormhole",
"version": "0.5.2",
"description": "Render a child view somewhere else in the DOM.",
"keywords": [
"ember-addon"
],
"license": "MIT",
"author": "Yapp Labs",
"directories": {
"doc": "doc",
"test": "tests"
},
"repository": "https://github.com/yapplabs/ember-wormhole.git",
"scripts": {
"start": "ember server",
"build": "ember build",
"test": "ember test"
},
"repository": "https://github.com/yapplabs/ember-wormhole.git",
"engines": {
"node": ">= 4"
"dependencies": {
"ember-cli-babel": "^6.8.2",
"ember-cli-htmlbars": "^2.0.1"
},
"author": "Yapp Labs",
"license": "MIT",
"devDependencies": {
"broccoli-asset-rev": "^2.4.5",
"chai": "^4.1.0",
"ember-cli": "~2.14.1",
"ember-cli-app-version": "^1.0.0",
"ember-cli-dependency-checker": "^1.3.0",
"ember-cli-eslint": "^3.0.0",
"ember-cli-github-pages": "0.0.6",
"ember-cli-htmlbars-inline-precompile": "^0.4.3",
"chai": "^4.1.2",
"ember-cli": "~2.16.2",
"ember-cli-dependency-checker": "^2.0.0",
"ember-cli-eslint": "^4.0.0",
"ember-cli-github-pages": "0.1.2",
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
"ember-cli-inject-live-reload": "^1.4.1",
"ember-cli-qunit": "^4.0.0",
"ember-cli-release": "^0.2.9",
"ember-cli-shims": "^1.1.0",
"ember-cli-sri": "^2.1.0",
"ember-cli-uglify": "^1.2.0",
"ember-cli-uglify": "^2.0.0",
"ember-code-snippet": "^1.3.0",
"ember-disable-prototype-extensions": "^1.1.2",
"ember-export-application-global": "^2.0.0",
"ember-fastboot-addon-tests": "^0.4.0",
"ember-load-initializers": "^1.0.0",
"ember-resolver": "^4.0.0",
"ember-source": "~2.14.1",
"ember-source": "~2.16.0",
"loader.js": "^4.2.3"
},
"keywords": [
"ember-addon"
],
"dependencies": {
"ember-cli-babel": "^6.7.1",
"ember-cli-htmlbars": "^2.0.1"
"engines": {
"node": "^4.5 || 6.* || >= 7.*"
},
"ember-addon": {
"configPath": "tests/dummy/config",
Expand Down
16 changes: 13 additions & 3 deletions testem.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,20 @@ module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
launch_in_ci: [
'PhantomJS'
'Chrome'
],
launch_in_dev: [
'PhantomJS',
'Chrome'
]
],
browser_args: {
Chrome: {
mode: 'ci',
args: [
'--disable-gpu',
'--headless',
'--remote-debugging-port=9222',
'--window-size=1440,900'
]
},
}
};
4 changes: 2 additions & 2 deletions tests/dummy/app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

{{content-for "head"}}

<link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
<link rel="stylesheet" href="{{rootURL}}assets/dummy.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/dummy.css">

{{content-for "head-footer"}}
</head>
Expand Down
2 changes: 1 addition & 1 deletion tests/helpers/module-for-acceptance.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { resolve } from 'rsvp';
import { module } from 'qunit';
import { resolve } from 'rsvp';
import startApp from '../helpers/start-app';
import destroyApp from '../helpers/destroy-app';

Expand Down
4 changes: 2 additions & 2 deletions tests/helpers/start-app.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { run } from '@ember/runloop';
import { merge } from '@ember/polyfills';
import Application from '../../app';
import config from '../../config/environment';
import { merge } from '@ember/polyfills';
import { run } from '@ember/runloop';

export default function startApp(attrs) {
let attributes = merge({}, config.APP);
Expand Down
Loading

0 comments on commit adece04

Please sign in to comment.