Skip to content

Handle OneSignal init rejection on non-yap.town origins #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anchpop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle OneSignal init rejection on non-yap.town origins #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions yap-frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@

console.log(`OneSignal initializing in ${isDevelopment ? 'development' : 'production'} mode`);

// OneSignal's app is restricted to https://yap.town, so init rejects on
// other origins (e.g. the yap-beta *.pages.dev channel). Push just
// isn't available there; don't surface it as an error.
try {
await OneSignal.init({
...config,
notifyButton: {
Expand All @@ -41,6 +45,9 @@
serviceWorkerParam: { scope: "/push/onesignal/" },
serviceWorkerPath: "push/onesignal/OneSignalSDKWorker.js"
});
} catch (e) {
console.info("OneSignal unavailable on this origin", e);
}
});
</script>

Expand Down
Loading