Skip to content

Conversation

@ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Jun 12, 2025

A general rework. Prioritizing stability over features atm.

Wavelength mappings currently removed because a standard calibration procedure is not yet in place (coming soon). No wavelength mappings in the meantime. Wavelength mappings are done in post-processing.
ROI and orientation reworked and invariant. Selecting ROI will be pushed at a later time.

  • dependencies refined: remove scipy, and instrumental replaced with the correct package instrumental-lib. Minimal dependencies in pyproject.toml
  • logging works
  • reworked measure function (non-blocking, builtin cosmic ray filter, averaging works)
  • data includes not just camera, but em gain and exposure time (i.e. can be dynamic for acquisition)

wright-stuff and others added 30 commits June 3, 2025 13:45
async workflow implemented,
multiple readouts working
remove frame_processing_method
remove trigger_response
also: fix merge oversights
basic testing working
ignore type errors
remove channel shape manipulators from set_spectrometer_mode
ddkohler and others added 27 commits June 11, 2025 14:29
arranging the parameters I _want_ to use, but they are yet to be implemented.
* more concise treatment of logging

picam imports with all others, yet logging handlers are maintained

* when not busy, update and commit params

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update pyproject.toml

* Update _pi_proem.py

* CI: avoid dll libraries

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* revert instrumental imports to inside daemon

* WIP--incomplete handling of measure errors

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* refactor measure [minor]

* more stops and starts

* fix enum setter

apparently this was broken?

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* hot pixel filter -- first attempt

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* test outlier rejection

* hot pixel correction attempt

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update gui.py

* Update _pi_proem.py

hot pixel filter tweaked to better reflect baseline values--better performance

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* allow dynamic readout count, exposure

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* robust start, stop

avoid using IsAcquisitionRunning, which seems unreliable

* stop_acquisition is more thorough

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Daniel Kohler <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ddkohler ddkohler marked this pull request as ready for review October 14, 2025 16:15
@ddkohler ddkohler changed the title [WIP] rearrange roi, spectrometer large scale cleanup Oct 20, 2025
@ddkohler ddkohler merged commit a1cb230 into main Oct 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants