Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jlcpcb: include board name in gerbers.zip instead of just "gerbers.zip" #493

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jenda122
Copy link

@jenda122 jenda122 commented Feb 7, 2023

Output of "fab jlcpcb" is named "gerbers.zip" which makes it somewhat difficult when uploading multiple boards to JLC cart.

This changes the default name (unless --nametemplate is specified) to <board_name>-gerbers.zip.

@yaqwsx
Copy link
Owner

yaqwsx commented Feb 20, 2023

Hi, sorry for the long delay in reviewing. The original idea for gerbers.zip was that you have multiple directories named according to the board, and you want to post-process them automatically; thus, you benefit from having the same name.

However, as I learned myself, this makes your life more complicated when ordering multiple PCBs from JLC. So I would like to change this.

However, I am aware of several usages out there that rely on the naming, so changing this would be a breaking change. Therefore, I would would like to include in a new major release that is planned after an upcoming minor release that adds v7 support.

@yaqwsx yaqwsx force-pushed the master branch 3 times, most recently from 8e0fcb8 to 5445c99 Compare February 24, 2024 09:21
@jj-uk
Copy link

jj-uk commented Feb 25, 2024

Would it not make more sense to change this so that when a flag is present (e.g. --prefixGerbersWithBoardName), the board name is added, otherwise it defaults to "gerbers.zip" ? That would prevent this from being a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants