Repository navigation
chore(site-root): remove the CNAME Pages left in the site root - #283
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
After the merge: Deploy docs green, gh-pages f9e17b5, both pods serving it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy run builds on the previous gh-pages and only adds root files, so the CNAME dropped from site-root in #282 stays in the published root (doc.yarilomail.org/CNAME answers 200).
site-root.mjs rootnow removes it by name. Checked locally: a scratch site root with a CNAME has none afterroot. After merge: /CNAME gives 404.