Switch to Apache POI for XLSX support. Fixes #136#175
Draft
tfmorris wants to merge 1 commit intoyarl:masterfrom
Draft
Switch to Apache POI for XLSX support. Fixes #136#175tfmorris wants to merge 1 commit intoyarl:masterfrom
tfmorris wants to merge 1 commit intoyarl:masterfrom
Conversation
This has only received VERY LIMITED testing. It now writes .xlsx files and reads either .xls or .xlsx In addition to testing, packaging should also be reviewed. It may be possible to remove some of the bundled JARs (or better yet, switch to Maven for dependency management).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
This is a proof of concept port to Apache POI. It has only received VERY LIMITED testing and I'm not a picture uploader, so someone else who actually uses the tool should take it over and make sure it works as expected.
It now writes .xlsx files and reads both .xls and .xlsx. Apache POI doesn't seem to support column autosize for .xls files, so I didn't make it an option to write that format.
In addition to testing, packaging should also be reviewed. It may be possible to remove some of the bundled JARs (or better yet, switch to Maven for dependency management). The current build size is 29MB up from the previous 13MB.