[WIP] Wrong func argument is internal error #2269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii Levitskii <[email protected]>
biosvs
force-pushed
the
wrong-func-argument-is-internal-error
branch
from
5d9f758
to
6fa8d16
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2269 +/- ##
==========================================
- Coverage 85.23% 85.22% -0.02%
==========================================
Files 270 270
Lines 15555 15557 +2
==========================================
Hits 13258 13258
Misses 1876 1876
- Partials 421 423 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2251
Invalid argument passed to a function doesn't mean that we should return InvalidArgument error. For those cases we should return InternalError, because client can't fix this problem by changing request.