Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2 tchannel refactoring] Renamed headerCallerProcedureToRequest to transportHeadersToRequest #2274

Open
wants to merge 1 commit into
base: tchannel-refactoring-1
Choose a base branch
from

Conversation

biosvs
Copy link
Collaborator

@biosvs biosvs commented May 7, 2024

headerCallerProcedureToRequest was dedicated to one particular header, transportHeadersToRequest dedicated to all the potential headers that should be parsed from transport.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (1d693b7) to head (08690c2).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           tchannel-refactoring-1    #2274   +/-   ##
=======================================================
  Coverage                   85.30%   85.31%           
=======================================================
  Files                         272      272           
  Lines                       15632    15630    -2     
=======================================================
- Hits                        13335    13334    -1     
+ Misses                       1875     1874    -1     
  Partials                      422      422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biosvs biosvs changed the title Renamed headerCallerProcedureToRequest to transportHeadersToRequest [2/2 tchannel refactoring] Renamed headerCallerProcedureToRequest to transportHeadersToRequest May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants