forked from qax-os/excelize
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature implementation from commits 4e6457a..8f87131 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yashuatla
wants to merge
15
commits into
feature-base-2
Choose a base branch
from
feature-head-2
base: feature-base-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mory usage and 50% time cost (qax-os#1935) Co-authored-by: zhayt <[email protected]>
…nge (qax-os#1941) - Add unit test for get pivot table with across worksheet data range, update dependencies package and updated comments of the GetMergeCells function
… hyperlink by None linkType - Update unit tests
…Axis data type (qax-os#1946) - Introduce new exported ChartTickLabelPositionType enumeration - Update unit tests
… for zero numeric cell value (qax-os#1947) - Updated unit tests
…l is empty in pivot table data range - Update unit tests
qax-os#1953) Co-authored-by: Simmons <[email protected]>
…ith an IEEE 754 "not-a-number" value or infinity
…ed drawing object
…e without sysClr
- Fix missing conditional formatting after remove column - Fix the SetSheetVisible function panic on none views sheet - Updated unit tests
…eld in the PivotTableField data type - Support set and get built-in number format of the pivot table data filed cells - Update unit tests - Fixed ineffectual assignment issue
…icers (qax-os#1943) - Update unit tests
…ion tags and ID (qax-os#1951) - Update unit tests for specified date and time format code
- Updated unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactor DeleteTable Function to Use getTables()
Overview
This PR refactors the DeleteTable function to use the getTables() method instead of iterating through sheets and getting tables for each sheet separately, improving code efficiency.
Change Types
Affected Modules
table.go