Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy text and add Text Mesh Pro support #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ababilinski
Copy link

Replaces the legacy text component with text mesh pro. This also updates FileBrowser.CalculateLengthOfDropdownText() to calculate size based on TMP_FontAsset

@yasirkula
Copy link
Owner

Thank you for the pull request. For now, I'd like to keep the plugin as is and provide optional upgrade path via this plugin: https://github.com/yasirkula/UnityTextToTextMeshProUpgradeTool#upgrading-simplefilebrowser

@ababilinski
Copy link
Author

Hi @yasirkula, I recommend updating to Text Mesh Pro since Unity UI Text is considered legacy and won't be updated,

The main reason for the pull request is to improve XR support for the asset. Using a world canvas with the legacy text component can lead to strange artifacts and blurry text. (see image of artifacts below)

image showing text artifacting when toggling a world canvas on and off

Using your other helpful tool makes the conversion a lot easier, but it can cause merge conflicts when trying to keep the plugin inside a project up to date.

@yasirkula
Copy link
Owner

yasirkula commented Jun 20, 2023

Hmm, I may switch to TMP completely as you've suggested. For the time being though, my backlog is overflowing with other tasks (namely daily job tasks and RuntimeInspector tasks). Afterwards, I'd like to use my tool to convert to TMP which I'm used to 🐱

@yasirkula
Copy link
Owner

Thanks for bringing this to my attention BTW. I don't think I was aware of the black text issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants