Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 3.4 #25

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Upgrade to Ruby 3.4 #25

merged 3 commits into from
Jan 14, 2025

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jan 14, 2025

Problem

  • The container does not build anymore and the last successful build contains the previous Ruby 3.3 packages which cause problems with the new Ruby 3.4

Solution

  • Upgrade the dependencies to Ruby 3.4
  • Drop the raspell gem, it does not compile with Ruby 3.4 and is used only in the yast.github.io repository for spellchecking

Notes

  • I'll remove the spellchecker call from the yast.github.io repository

Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

It does not compile with Ruby 3.4 and is used only in the
yast.github.io repository for spellchecking.
@mvidner
Copy link
Member

mvidner commented Jan 14, 2025

For the record, I spent 30 minutes trying to fix raspell, so I made a PR for it (even if it is a dead end)
evan/raspell#15

Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaand CI passes, thanks!

@lslezak lslezak merged commit 479ad05 into master Jan 14, 2025
2 checks passed
@lslezak lslezak deleted the ruby3.4 branch January 14, 2025 15:02
Copy link

✅ Autosubmission job #12770410490 successfully finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants