Move settings section#113
Open
marc0777 wants to merge 2 commits into
Open
Conversation
Fixes a problem in the error modal, where onClose wasn't populated. Also fixes the role controller to always have a body, to avoid erroring out on empty json response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little quality of life improvement for this plugin.
It moves the settings page to Strapi settings, freeing up some space on the left menu.
Also moved the plugin permission configuration inside the settings section, and gave a more meaningful name to the flag. I haven't changed the
uid, so current permissions should be preserved.