fix: Add state param in Azure AD provider#89
Merged
Conversation
ww24
commented
Apr 1, 2025
Comment on lines
+92
to
+98
| if (!userResponse.data.email) { | ||
| throw new Error('Email address is not set. Please set email property to the Azure AD user.'); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I lost some time to realize that the email property was not set for the Azure AD User. I add an error message for clarity.
Contributor
Author
There was a problem hiding this comment.
It is possible that someone who forgot to specify an email address for Azure AD users has submitted a Pull Request like this. Usually, the userinfo endpoint is sufficient.
ww24
force-pushed
the
fix/use-state-in-azuread
branch
from
0e523e5 to
1e05d62
Compare
yasudacloud
pushed a commit
that referenced
this pull request
May 13, 2025
* refactor: Refactor URL construction in Azure AD provider * fix: Ensure email property is set for Azure AD user in sign-in callback * fix: Add state param in Azure AD provider
yasudacloud
added a commit
that referenced
this pull request
May 13, 2025
* fix: Use PKCE in Cognito provider (#82) * fix: Use PKCE in Google provider (#83) * fix: Use PKCE in OIDC provider (#86) * fix: Use PKCE in OIDC provider * fix: ensure state parameter is always appended in OIDC provider * fix: Add state param in Google provider (#90) * refactor: Refactor URL construction in Google provider * fix: Add state param in Google provider * refactor: generating random bytes * fix: Add state param in Cognito provider (#88) * refactor: Refactor URL construction in Cognito provider * fix: Add state param in Cognito provider * fix: Add state param in Azure AD provider (#89) * refactor: Refactor URL construction in Azure AD provider * fix: Ensure email property is set for Azure AD user in sign-in callback * fix: Add state param in Azure AD provider * fix: Add state param in OIDC provider (#91) * fix require --------- Co-authored-by: Takenori Nakagawa <ww24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #87 in Azure AD provider.