Skip to content

fix: Add state param in OIDC provider #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yasudacloud merged 1 commit into from
May 8, 2025
+10 −1
Merged

fix: Add state param in OIDC provider #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion server/controllers/oidc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import axios from 'axios';
import {Buffer} from 'buffer';
import { randomUUID } from 'crypto';
import pkceChallenge from "pkce-challenge";

Expand All @@ -16,7 +17,7 @@ const configValidation = () => {
}

const oidcSignIn = async (ctx) => {
const { state } = ctx.query;
let { state } = ctx.query;
const { OIDC_CLIENT_ID, OIDC_REDIRECT_URI, OIDC_SCOPES, OIDC_AUTHORIZATION_ENDPOINT } = configValidation();

// Generate code verifier and code challenge
Expand All @@ -26,6 +27,11 @@ const oidcSignIn = async (ctx) => {
// Store the code verifier in the session
ctx.session.codeVerifier = codeVerifier;

if (!state) {
state = crypto.getRandomValues(Buffer.alloc(32)).toString('base64url');
}
ctx.session.oidcState = state;

const params = new URLSearchParams();
params.append('response_type', 'code');
params.append('client_id', OIDC_CLIENT_ID);
Expand All @@ -51,6 +57,9 @@ const oidcSignInCallback = async (ctx) => {
if (!ctx.query.code) {
return ctx.send(oauthService.renderSignUpError(`code Not Found`))
}
if (!ctx.query.state || ctx.query.state !== ctx.session.oidcState) {
return ctx.send(oauthService.renderSignUpError(`Invalid state`))
}

const params = new URLSearchParams();
params.append('code', ctx.query.code);
Expand Down