Allow uploaded custom logos for loop icons - #1496
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loops can now use an uploaded logo instead of only the built-in icons. The existing picker accepts SVG, PNG, JPEG, WebP, and GIF files up to 2 MB, converts them to a small PNG, and saves the icon with the loop. The same image appears in Loops and Inbox; Use default restores the source icon.
The API accepts bounded PNG data URLs alongside existing named icons. Raw SVG and remote URLs are rejected, and existing ownership checks remain intact.
Validation: 57 affected core tests, 80 affected web tests, both typechecks, lint, and independent review passed. Live Postgres-backed browser QA exercised Sentry SVG upload, reset, re-upload, persistence, and Inbox rendering.
Screenshots use synthetic local data. The example glyph comes from Sentry’s official branding page.